Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: spi: gecko: Add new driver for SPI communication via EUSART #77353

Merged

Conversation

Terezvent
Copy link
Contributor

@Terezvent Terezvent commented Aug 21, 2024

Added a new driver to support SPI communication via EUSART. Since the Silabs
EFR32MG24 family SoCs have only one USART, EUSART support is necessary for
implementing SPI functionality.

Reference manual: https://www.silabs.com/documents/public/reference-manuals/efr32xg24-rm.pdf

@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 21, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

dts/bindings/spi/silabs,gecko-spi-eusart.yaml Outdated Show resolved Hide resolved
drivers/spi/spi_gecko_eusart.c Outdated Show resolved Hide resolved
drivers/spi/spi_gecko_eusart.c Outdated Show resolved Hide resolved
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch from e9ecad8 to 31e43f3 Compare August 23, 2024 01:23
@Terezvent Terezvent marked this pull request as ready for review August 23, 2024 01:27
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch from 31e43f3 to ea9dfca Compare August 23, 2024 01:52
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Aug 23, 2024
@Terezvent Terezvent changed the title Silabs gecko spi-eusart drivers: spi: gecko: Add new driver for SPI communication via EUSART Aug 23, 2024
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch 3 times, most recently from 8f8a9cf to 6bd0451 Compare August 23, 2024 20:10
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No HALisms in DT please

dts/bindings/spi/silabs,gecko-spi-eusart.yaml Outdated Show resolved Hide resolved
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch from 6bd0451 to 1bdaaf9 Compare August 28, 2024 15:11
@Terezvent Terezvent requested a review from gmarull August 28, 2024 15:20
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch from 1bdaaf9 to e611ade Compare August 28, 2024 17:10
tbursztyka
tbursztyka previously approved these changes Aug 28, 2024
@Terezvent Terezvent requested a review from Sylphe88 October 7, 2024 23:43
jerome-pouiller
jerome-pouiller previously approved these changes Oct 8, 2024
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch from 8f2c6a3 to 2b6c892 Compare October 9, 2024 01:25
drivers/spi/spi_gecko_eusart.c Outdated Show resolved Hide resolved
drivers/spi/spi_gecko_eusart.c Outdated Show resolved Hide resolved
drivers/spi/spi_gecko_eusart.c Outdated Show resolved Hide resolved
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch from 2b6c892 to c97d3f6 Compare October 10, 2024 04:32
@Terezvent Terezvent requested a review from gmarull October 10, 2024 04:34
@Terezvent Terezvent force-pushed the silabs-gecko-spi-eusart branch from c97d3f6 to 97c58e7 Compare October 10, 2024 05:28
asmellby
asmellby previously approved these changes Oct 10, 2024
drivers/spi/spi_gecko_eusart.c Outdated Show resolved Hide resolved
Added a new driver to support SPI communication via EUSART. Since the
Silabs EFR32MG24 family SoCs have only one USART, EUSART support is
necessary for implementing SPI functionality.

Signed-off-by: Teresa Zepeda Ventura <[email protected]>
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbursztyka could you take a look? Thanks.

@Terezvent
Copy link
Contributor Author

Hello @gmarull Could you help me to review this pull request, please.
I already added the changes you requested.

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit, can be fixed later

bool "Gecko EUSART SPI controller driver"
default y
depends on DT_HAS_SILABS_GECKO_SPI_EUSART_ENABLED
depends on GPIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends on GPIO
select GPIO

@henrikbrixandersen henrikbrixandersen merged commit 6773f33 into zephyrproject-rtos:main Oct 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants